-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use MT5 builtin’s translation system on all the modpack #529
base: master
Are you sure you want to change the base?
Conversation
c1d77c2
to
f484b21
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to rework on some points
@louisroyer TODO:
|
Instead of increasing formspec width, those two lines could be moved below the upgrade slots and power level. The digiline channel button could be moved to the right or left side of the upgrade slots. |
can't this be done in another PR? This one is about translations only. |
ok, I created a new issue #562 and will fix this in another PR. |
…()` output Since they are not translated anyway.
And preserve compatibility with [toolranks mod](https://github.com/lisacvuk/minetest-toolranks/).
Note: nodes to convert from steel blocks to wroughtiron blocks now require to be added manually since doing this automatically breaks translations.
Using [update_translations](https://github.com/minetest-tools/update_translations) tool. Also renamed translations files.
Rebased and removed unused/duplicates translations. |
Sorry, I didn't remember there was a PR to change the translation system. Would you - at any chance - have time to rebase this PR? To reduce additional work, it might make sense to reorder and squash related commits using EDIT:
Yes, I am aware of that, but fixing it belongs to another PR. |
I will try to have a look at this before the end of the month. |
@louisroyer Would you like to continue on this PR sometime? |
If you are using an already created map to test this PR, you may need to break and replace some nodes (like chests) to see effects.