Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MT5 builtin’s translation system on all the modpack #529

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

louisroyer
Copy link
Contributor

If you are using an already created map to test this PR, you may need to break and replace some nodes (like chests) to see effects.

Copy link
Contributor Author

@louisroyer louisroyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to rework on some points

@louisroyer
Copy link
Contributor Author

louisroyer commented Aug 12, 2020

@louisroyer TODO:

  • rebase
  • re-test

@louisroyer
Copy link
Contributor Author

Note: some strings on battery box nodes overflow the formspec (but it is not a regression since this also occurs on master). Must I fix the size of the formspec in this PR (by extending on the right) or do it in another one?
example:
2020-08-12-214801_536x539_scrot

@auouymous
Copy link
Contributor

Instead of increasing formspec width, those two lines could be moved below the upgrade slots and power level. The digiline channel button could be moved to the right or left side of the upgrade slots.

@BuckarooBanzay
Copy link
Member

Instead of increasing formspec width, those two lines could be moved below the upgrade slots and power level. The digiline channel button could be moved to the right or left side of the upgrade slots.

can't this be done in another PR? This one is about translations only.

@louisroyer
Copy link
Contributor Author

can't this be done in another PR? This one is about translations only.

ok, I created a new issue #562 and will fix this in another PR.

@louisroyer
Copy link
Contributor Author

Rebased and removed unused/duplicates translations.

@OgelGames OgelGames mentioned this pull request Jun 9, 2022
5 tasks
@SmallJoker
Copy link
Member

SmallJoker commented Jun 9, 2022

Sorry, I didn't remember there was a PR to change the translation system.

Would you - at any chance - have time to rebase this PR? To reduce additional work, it might make sense to reorder and squash related commits using git rebase -i HEAD~20. Also feel free to open a PR per mod, if you'd prefer to split the work.

EDIT:

Note: some strings on battery box nodes overflow the formspec

Yes, I am aware of that, but fixing it belongs to another PR.

@louisroyer
Copy link
Contributor Author

I will try to have a look at this before the end of the month.

@SmallJoker
Copy link
Member

@louisroyer Would you like to continue on this PR sometime?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants